fix: use HTTPS in Playwright webServer config#240
Merged
brendanjryan merged 4 commits intomainfrom Apr 7, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
08909ce to
51ccb90
Compare
51ccb90 to
89c6873
Compare
89c6873 to
60b7309
Compare
60b7309 to
72d3f8e
Compare
vite-plugin-mkcert forces the dev server onto HTTPS, but Playwright was checking http://localhost:5173. The health check never got a response, causing all E2E shards to time out after 60s. Switch baseURL and webServer.url to https:// and add ignoreHTTPSErrors to accept the self-signed cert.
72d3f8e to
fc9592f
Compare
fc9592f to
f6cf6dd
Compare
f6cf6dd to
b718d37
Compare
1. vite-plugin-mkcert forces HTTPS; update Playwright to use https://localhost:5173 with ignoreHTTPSErrors. 2. In CI, set VITE_E2E=true so the wagmi config uses the accounts SDK webAuthn connector (compatible with virtual authenticators) instead of tempoWallet (iframe dialog that blocks the page). Production continues to use tempoWallet. 3. Update E2E tests to click 'Sign in' (matching current Login UI).
b718d37 to
f27b132
Compare
The accounts/wagmi webAuthn connector expects { method: 'register', name }
instead of { type: 'sign-up', label } used by wagmi/tempo webAuthn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All E2E test shards have been failing with:
vite-plugin-mkcertforces the dev server onto HTTPS (https://localhost:5173), but Playwright'swebServer.urlwas set tohttp://localhost:5173. The health check never got a response, so all 3 shards timed out.Fix
baseURLandwebServer.urltohttps://localhost:5173ignoreHTTPSErrors: trueto bothuseandwebServerto accept the self-signed cert